Skip to content

34022 move director mailing validation to schema#4562

Closed
mruff-aeq wants to merge 2 commits into
bcgov:mainfrom
mruff-aeq:34022-move-director-mailing-validation-to-schema
Closed

34022 move director mailing validation to schema#4562
mruff-aeq wants to merge 2 commits into
bcgov:mainfrom
mruff-aeq:34022-move-director-mailing-validation-to-schema

Conversation

@mruff-aeq

@mruff-aeq mruff-aeq commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Issue #: /bcgov/entity#34022

Description of changes:
Removed the CORPS-only director mailingAddress presence check from legal-api since that validation now lives in the schema (directors.json requires mailingAddress); the deps temporarily reference my fork of business-schemas for pre-merge testing and will be pointed back to bcgov once the schema PR is merged and tagged.

Testing

curl -sS -i -X POST \
  "http://127.0.0.1:5000/api/v2/businesses/CP0000019/filings?only_validate=true" \
  -H "Authorization: Bearer $TOKEN" \
  -H "x-apikey: KHGuiTxG52ejzFZi7wu4QyD8GdVGEMAz" \
  -H "account-id: 3040" \
  -H "Content-Type: application/json" \
  --data-binary @B_missing_mailing.json

Raw response:
HTTP/1.1 422 UNPROCESSABLE ENTITY
Content-Type: application/json
API: legal_api/3.1.0
SCHEMAS: registry_schemas/2.18.74
Connection: close

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@mruff-aeq mruff-aeq requested a review from kialj876 July 9, 2026 15:21
@mruff-aeq mruff-aeq force-pushed the 34022-move-director-mailing-validation-to-schema branch from e31d266 to 1f806f2 Compare July 9, 2026 15:30
@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2026

Copy link
Copy Markdown

@mruff-aeq

Copy link
Copy Markdown
Collaborator Author

Closing — tech-debt cleanup blocked. Can't move mailingAddress to schema (shared director def, no legalType to scope by; would reject existing coop directors). Not worth pursuing.

@mruff-aeq mruff-aeq closed this Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant